Skip to content

Add a Cursor cloud agent environment using the E2E fake GitHub - #1083

Merged
ogi-m merged 1 commit into
masterfrom
cursor-cloud-agent-env
Nov 12, 2026
Merged

ogi-m merged 1 commit into
masterfrom
cursor-cloud-agent-env

Conversation

@ogi-m

@ogi-m ogi-m commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a Cursor cloud agent environment (.cursor/) that runs the plugin on a local Mattermost server against the fake GitHub from e2e/integration/fake-github/, so no GitHub credentials are needed. The Docker setup matches the GitLab plugin's.

  • environment.json, Dockerfile, install.sh, start.sh: image, startup and agent instructions.
  • fake-github.ts: runs the fake on its own and seeds it with a signed-in user, an org and a repo.

No plugin or test code changes; CI is unaffected.

Change Impact: 🟢 Low

Changes Breakdown:

+273 -0 Production Changes (100%)
+0 -0 Test Changes (0%)

Regression Risk: The changes add developer tooling under .cursor/ only and do not modify plugin or test code, so runtime regression risk is minimal. The main side effects occur in the agent environment, where start.sh edits /etc/hosts and changes Docker socket access.

Generated by CodeRabbitAI

@ogi-m
ogi-m requested a review from a team as a code owner November 12, 2026 10:52
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

This pull request adds a Cursor development environment for the Mattermost GitHub plugin. It configures an Ubuntu image and Docker startup, and adds scripts to prepare the E2E environment and start or reseed the fake GitHub server.

Changes: Cursor E2E Environment

Layer / File(s) Summary
Development image and Cursor configuration
.cursor/Dockerfile, .cursor/environment.json
Adds an Ubuntu-based image and configures Cursor to use it. The configuration declares the github-stack terminal command and the Mattermost port.
Docker startup and readiness
.cursor/start.sh
Checks Docker readiness, attempts startup when needed, configures the fake-github hosts entry and socket access, and attempts Docker Hub login when credentials are set.
E2E setup and fake GitHub seeding
.cursor/fake-github.ts, .cursor/install.sh
Adds a script to start or reseed the fake GitHub server. The installation script checks tool versions, builds and prepares the E2E environment, and handles stack cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to ccf83

This adds a Cursor development environment and leaves plugin and test code unchanged. No merge-blocking risk was identified, so production behavior and CI should be unaffected.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: adding a Cursor cloud agent environment (the .cursor/ setup with Dockerfile, environment.json, install.sh and start.sh) that runs the plugin against the E2E fake GitH…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: adding a Cursor cloud agent environment (the .cursor/ setup with Dockerfile, environment.json, install.sh and start.sh) that runs the plugin against the E2E fake GitHub. The changeset matches this, as the summaries show only .cursor/ files and no plugin or test code changes. The title is concise and specific, and it uses no vague terms.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb04c84e-280d-418f-8763-2379c6256fea
Commits

Reviewing files that changed from the base of the PR and between ad523ec and ccf8360.

Files selected for processing: 5

  • .cursor/Dockerfile
  • .cursor/environment.json
  • .cursor/fake-github.ts
  • .cursor/install.sh
  • .cursor/start.sh

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@avasconcelos114 avasconcelos114 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested on a live agent and everything works

@ogi-m
ogi-m merged commit bcbfe13 into master Nov 12, 2026
18 checks passed
@ogi-m
ogi-m deleted the cursor-cloud-agent-env branch November 12, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants